Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E111: Not showing the indent size #1327

Closed
ndunnewind opened this issue May 7, 2021 · 4 comments · Fixed by #1328
Closed

E111: Not showing the indent size #1327

ndunnewind opened this issue May 7, 2021 · 4 comments · Fixed by #1328
Milestone

Comments

@ndunnewind
Copy link

Since PyCQA/pycodestyle#970, the E111 rule does not show the indent size when using pycodestyle through flake8. Whereas the check first printed E111 indentation is not a multiple of four, it now prints E111 indentation is not a multiple of . This does seem to happen because flake8 overwrites the indent_size_str variable here.

@asottile asottile transferred this issue from PyCQA/pycodestyle May 7, 2021
@sigmavirus24
Copy link
Member

Wish I could thumbs up a historical item (@asottile beating me to migrating this to flake8)

@asottile
Copy link
Member

asottile commented May 7, 2021

this is my bad, I misinterpreted what that argument was supposed to mean

admittedly, I think it makes not much sense to try and translate the number into english so I think I'll fix this in both places, but to just the numeric string (and deprecate the attribute in flake8)

@asottile
Copy link
Member

asottile commented May 8, 2021

here's the pycodestyle side: PyCQA/pycodestyle#995
and the flake8 side: #1328

@asottile asottile added this to the 3.9.2 milestone May 8, 2021
@asottile
Copy link
Member

asottile commented May 8, 2021

also released as 3.9.2 -- thanks again for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants