Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev dependency identified as first party instead of third party #1098

Closed
rommguy opened this issue Jan 13, 2020 · 2 comments
Closed

Dev dependency identified as first party instead of third party #1098

rommguy opened this issue Jan 13, 2020 · 2 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@rommguy
Copy link

rommguy commented Jan 13, 2020

First, thank you very much for this great tool, it is super helpful.

We use poetry to install dependencies, and we see a this bug -
Packages defined in our pyproject.toml as dev dependencies are identified as first party instead of first party.
However, they are external to the project and are actually third party

we use isort version 4.3.21 on OSX

@toumorokoshi
Copy link

You may want to see #1104 as well, I believe this is for similar reasons.

@timothycrosley
Copy link
Member

This should be fixed for the 5.0.0 release in spirit via this ticket: #1147

@timothycrosley timothycrosley added duplicate This issue or pull request already exists enhancement New feature or request labels Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants