Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why third_party and my_lib have not blank lines in 5.1.4 version. #1352

Closed
549982170 opened this issue Jul 27, 2020 · 1 comment
Closed

Why third_party and my_lib have not blank lines in 5.1.4 version. #1352

549982170 opened this issue Jul 27, 2020 · 1 comment
Labels
documentation Improvements or additions to documentation question Further information is requested repo_needed Can't currently reproduce, if reproduction steps are added we will resivit this issue.

Comments

@549982170
Copy link

Why third_party and my_lib have not blank lines in 5.1.4 version.

@timothycrosley
Copy link
Member

I'm sorry you are experiencing this issue!

Please check the upgrade guide here: https://timothycrosley.github.io/isort/docs/upgrade_guides/5.0.0/#module-placement-changes-known_third_party-known_first_party-default_section-etc and see if it addresses your issue. likely you simply need to remove config options in the new version to get the appropriate behaviour.

Here is the background of why the change: #1147
Example #1 of working through the upgrade process with a user: #1336
Example #2 of working through the upgrade process with a user: #659 (comment)

If none of these solve your issue, please let me know by opening up a new issue referencing this one.

Thanks!

~Timothy

@timothycrosley timothycrosley added repo_needed Can't currently reproduce, if reproduction steps are added we will resivit this issue. question Further information is requested documentation Improvements or additions to documentation labels Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested repo_needed Can't currently reproduce, if reproduction steps are added we will resivit this issue.
Projects
None yet
Development

No branches or pull requests

2 participants