Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offical github action? #1493

Closed
michaeloliverx opened this issue Sep 22, 2020 · 4 comments 路 Fixed by #1538
Closed

Offical github action? #1493

michaeloliverx opened this issue Sep 22, 2020 · 4 comments 路 Fixed by #1538
Labels
enhancement New feature or request Hacktoberfest help wanted Extra attention is needed

Comments

@michaeloliverx
Copy link

It would be nice to have an official GitHub action 馃槃, are there any plans for it?

@timothycrosley timothycrosley added enhancement New feature or request help wanted Extra attention is needed labels Sep 24, 2020
@timothycrosley
Copy link
Member

There are now 馃槈 I think it would be nice to have an official github action and am happy to accept a PR that adds one

@jamescurtin
Copy link
Contributor

I believe it is preferable for an action to live in a standalone repo: in addition to it being a cleaner division, actions are semantically versioned based on released tags, which would conflict with the tagging scheme for the isort package.

For this reason, I've created python-isort action. I've also created this demonstration repository that shows examples of both a passing and a failing check.

If you have an interest in moving this action into an "official" isort organization, let me know and I can transfer the repo.

@timothycrosley
Copy link
Member

timothycrosley commented Oct 7, 2020

@jamescurtin this looks great! I agree with your assessment that it should be a separate repository. I've added you to the isort organization which should give you the power to transfer this repository into there while still maintaining access to it. That would make it the first official isort extension.

Would you be willing to:

  • Mark the repository as using the MIT license
  • Submit a small PR here to add documentation for this new action?

Thanks!

~Timothy

@jamescurtin
Copy link
Contributor

Sounds great! The license has been added & the repo is now in the isort organization.

Documentation PR has been submitted as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants