-
Notifications
You must be signed in to change notification settings - Fork 172
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Some 'breaking changes' here. Pyroma no longer provides TestSuite ratings, see https://github.com/regebro/pyroma/commit/4199479fa0df7de2c0d907458e6af888a9897045\#diff-e59624df44e0bd8d01fdfa6baea1e0e2 Also PEP386Version became PEPVersion on https://github.com/regebro/pyroma/commit/505f5aba92d270e7badc9b8aa3aff05930d11bf1\#diff-e59624df44e0bd8d01fdfa6baea1e0e2 Signed-off-by: Carlos Coêlho <carlospecter@gmail.com>
- Loading branch information
Showing
2 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,7 +57,7 @@ | |
_OPTIONAL = { | ||
'with_frosted': ('frosted>=1.4.1',), | ||
'with_vulture': ('vulture>=0.6',), | ||
'with_pyroma': ('pyroma==2.0.2',), | ||
'with_pyroma': ('pyroma>=2.0.2',), | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
chocoelho
Author
Contributor
|
||
} | ||
with_everything = [req for req_list in _OPTIONAL.values() for req in req_list] | ||
_OPTIONAL['with_everything'] = sorted(with_everything) | ||
|
Follow-up to issue ( #253 ).
Given these were added in later versions of
pyroma
and are not backwards compatible, should we bump the version constraint as well to ensure we have a working version ofpyroma
? Looking at the commits referenced above, guessing this would be 2.2+. Does that sound right?