Skip to content

Commit

Permalink
Update pyroma support
Browse files Browse the repository at this point in the history
Some 'breaking changes' here. Pyroma no longer provides TestSuite ratings,
see https://github.com/regebro/pyroma/commit/4199479fa0df7de2c0d907458e6af888a9897045\#diff-e59624df44e0bd8d01fdfa6baea1e0e2

Also PEP386Version became PEPVersion on https://github.com/regebro/pyroma/commit/505f5aba92d270e7badc9b8aa3aff05930d11bf1\#diff-e59624df44e0bd8d01fdfa6baea1e0e2

Signed-off-by: Carlos Coêlho <carlospecter@gmail.com>
  • Loading branch information
chocoelho committed May 25, 2018
1 parent 7502179 commit d0c416a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions prospector/tools/pyroma/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
ratings.Name: 'PYR01',
ratings.Version: 'PYR02',
ratings.VersionIsString: 'PYR03',
ratings.PEP386Version: 'PYR04',
ratings.PEPVersion: 'PYR04',
ratings.Description: 'PYR05',
ratings.LongDescription: 'PYR06',
ratings.Classifiers: 'PYR07',
Expand All @@ -34,8 +34,8 @@
ratings.AuthorEmail: 'PYR11',
ratings.Url: 'PYR12',
ratings.License: 'PYR13',
ratings.ZipSafe: 'PYR14',
ratings.TestSuite: 'PYR15',
ratings.LicenceClassifier: 'PYR14',
ratings.ZipSafe: 'PYR15',
ratings.SDist: 'PYR16',
ratings.PackageDocs: 'PYR17',
ratings.ValidREST: 'PYR18',
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
_OPTIONAL = {
'with_frosted': ('frosted>=1.4.1',),
'with_vulture': ('vulture>=0.6',),
'with_pyroma': ('pyroma==2.0.2',),
'with_pyroma': ('pyroma>=2.0.2',),

This comment has been minimized.

Copy link
@jakirkham

jakirkham May 26, 2018

Contributor

Follow-up to issue ( #253 ).

Given these were added in later versions of pyroma and are not backwards compatible, should we bump the version constraint as well to ensure we have a working version of pyroma? Looking at the commits referenced above, guessing this would be 2.2+. Does that sound right?

This comment has been minimized.

Copy link
@chocoelho

chocoelho May 26, 2018

Author Contributor

That's right. This way we'd force an update on pyroma as well to force it to meet the requirements.

This comment has been minimized.

Copy link
@chocoelho

chocoelho May 26, 2018

Author Contributor

But it should be 2.3 due to LicenceClassifier.

This comment has been minimized.

Copy link
@jakirkham

jakirkham May 26, 2018

Contributor

Ah ok. Thanks for checking. :)

}
with_everything = [req for req_list in _OPTIONAL.values() for req in req_list]
_OPTIONAL['with_everything'] = sorted(with_everything)
Expand Down

0 comments on commit d0c416a

Please sign in to comment.