Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent exit code 2 for unavailable tools #162

Closed
jquast opened this issue Mar 5, 2016 · 3 comments
Closed

Silent exit code 2 for unavailable tools #162

jquast opened this issue Mar 5, 2016 · 3 comments

Comments

@jquast
Copy link
Contributor

jquast commented Mar 5, 2016

When landscape.yml or prospector.yaml declares to run a tool that is not installed, nothing happens and exit code 2 is returned by prospector.

Only when the --direct-tool-stdout argument is used, the true reason may be revealed, transcript follows:

$ cat .landscape.yml
frosted:
    run: true
$ cat xyz.py
bad syntax
$ prospector xyz.py
$ echo $?
2
$ prospector --direct-tool-stdout

Cannot run tool frosted as support was not installed.
Please install by running 'pip install prospector[with_frosted]'

$ prospector --version
prospector 0.11.7
$ python -V
Python 3.5.1

Suggest such output is revealed without use of --direct-tool-stdout

@carlio
Copy link
Member

carlio commented May 29, 2016

Oops that used to happen but I must have accidentally squashed it when trying to hide extraneous pylint output. I'll restore it, thanks!

carlio added a commit that referenced this issue May 29, 2016
… if stdout/err is squashed for dependent tools
@carlio
Copy link
Member

carlio commented May 29, 2016

Ok fixed in develop branch, will make it into next release shortly

@carlio carlio closed this as completed May 29, 2016
@carlio
Copy link
Member

carlio commented May 29, 2016

@jquast actually I discovered another issue here, turns out that pyroma 1.8.3 has a strange import loggings line which causes it to break and prospector was pinned to <2.0. You may run into further pyroma errors unless you manually upgrade pyroma. I'll fix the setup.py to not be so restrictive too.

carlio added a commit that referenced this issue May 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants