Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Version incompatibility between direct usage of pylint-plugin-utils and indirect usage via pylint-django #478

Closed
adamcunnington-mlg opened this issue Jan 17, 2022 · 3 comments

Comments

@adamcunnington-mlg
Copy link

prospector 1.5.3.1 includes the following requirements:
pylint-plugin-utils=^0.6"
pylint-django=^2.4.4"

The trouble is that pylint-django 2.5.0 just got released and it pins pylint-django as follows:
pylint-plugin-utils>=0.7

Therefore, you cannot install prospector now without ending up with an incompatible version of pylint-plugin-utils.

You can easily replicate this by using a installation tool with proper dependency evaluation like pip-tools or poetry.

Suggested Fix

  • Either explicitly pin prospector's dependency of pylint-django=2.4.4 (probably a good idea)
  • Or Change the ^ dependency to be >= for prospector's requirement of pylint-plugin-utils (probably a bad idea)
carlio added a commit to carlio/prospector that referenced this issue Jan 17, 2022
@carlio
Copy link
Member

carlio commented Jan 17, 2022

Oops, sorry! pylint-plugin-utils==0.7 was a release to fix the concurrent job support in pylint-django, otherwise things are mostly the same.

Therefore I'll bump the requirement in prospector to ^0.7 and make a bugfix release.

Let's see if tests work and if so, I'll make a 1.5.4 prospector release.

@carlio
Copy link
Member

carlio commented Jan 17, 2022

Drat, pylint-plugin-utils has python>=3.6.2 and prospector >=3.6.1 (both of which will go away soon since pylint itself drops 3.6 support soon).

However that means it's a bit more than a bugfix release, so I think solution here is:

  • release 1.5.4 with pylint-django = ~2.4.0 (just upgrade to 1.6)
  • Also release 1.6 with newer versions of both pylint django, pylint plugin utils and drop support for python 3.6.1.

carlio added a commit that referenced this issue Jan 17, 2022
… requirement for supporting latest pylint-django and pylint-plugin-utils
@carlio carlio mentioned this issue Jan 17, 2022
@carlio
Copy link
Member

carlio commented Jan 17, 2022

@adamcunnington-mlg 1.6.0 is on PyPI now with the proper version restrictions for those dependencies. Thanks for the report! I need to clean up this repository a bit :-)

@carlio carlio closed this as completed Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants