Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] --no-style-warnings option stopped working in 1.7.0 #488

Closed
f11r opened this issue Feb 25, 2022 · 5 comments · Fixed by #490
Closed

[BUG] --no-style-warnings option stopped working in 1.7.0 #488

f11r opened this issue Feb 25, 2022 · 5 comments · Fixed by #490

Comments

@f11r
Copy link

f11r commented Feb 25, 2022

It looks like the --no-style-warnings option stopped working in the newest release. It's still working in 1.6.0 but after upgrading to 1.7.0 we're now getting pycodestyle errors. It's probably related to the renaming from pep8 to pycodestyle?

@carlio
Copy link
Member

carlio commented Feb 25, 2022

@f11r you're probably right - can you post your configuration? Either the prospector profile or the command line arguments you are using?

@f11r
Copy link
Author

f11r commented Feb 25, 2022

Here's our command line call: prospector --no-style-warnings -X

As configuration we only have a .pylintrc file, nothing else.

@carlio
Copy link
Member

carlio commented Feb 25, 2022

@f11r As a workaround, I think if you create a .prospector.yml file with the contents:

pycodestyle:
  run: false

This should get you the old behaviour with 1.7. Or just pin to <1.7 and keep the old version.

I'll look into what happened but I think trying to be backwards compatible added an edge case. I'll create a bugfix release when I have one!

@carlio
Copy link
Member

carlio commented Feb 26, 2022

Fixed on master branch, will go out in a 1.7.1 release soon(ish)

@f11r
Copy link
Author

f11r commented Feb 26, 2022

@carlio Great to see this getting fixed so quickly 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants