Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #550 Pin flake8 to < 6 to allow pip-compile to succeed #551

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Fix #550 Pin flake8 to < 6 to allow pip-compile to succeed #551

merged 1 commit into from
Dec 3, 2022

Conversation

gopackgo90
Copy link
Contributor

flake8 6 drops support for python 3.7, prospector still supports python 3.7.

Description

Flake8 6 drops python 3.7 which prospector still supports, pinning flake8 to less than 6 should allow pip-compile to work on pythons 3.8+

Related Issue

#550

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the dependencies
  • I have updated the dependencies accordingly
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

flake8 6 drops support for python 3.7, prospector still supports python
3.7.
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I agree with your analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants