-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix undefined name sre_constants in Python 3.11 #552
Conversation
landscapeio#546 (comment) @gopackgo90 Your review, please.
There's still a warning in 3.11:
|
Good catch. Thanks. |
👍 |
I'm a little surprised this works on Python < 3.11, because on my own system, doing this sort of import doesn't work for me on Python 3.8:
I had anticipated a fix would be to do conditional imports like either jwilk/pydiatra@b69f3fc or The-Compiler/hypothesis@66ca462. |
Interesting because the CPython change that you highlighted was from 2008 (Python 3.0.0) which proceeds by a decade The changes made work like this...
|
Doing the import that way on Python 3.8 I get:
|
The tests are green, but maybe this file isn't even imported ? |
Or the two exceptions are never triggered. |
#546 (comment)
@gopackgo90 Your review, please.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: