Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix re._constants again #555

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Fix re._constants again #555

merged 1 commit into from
Dec 8, 2022

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 5, 2022 •
edited
Loading

Description

Fix discussed at #552 (comment)

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the dependencies
  • I have updated the dependencies accordingly
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Pierre-Sassoulas
Pierre-Sassoulas reviewed Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have some automated tests, as we saw the previous fix was going to crash on all interpreters except 3.11.

@gopackgo90
Copy link
Contributor

gopackgo90 commented Dec 6, 2022 •
edited
Loading

I don't know this codebase that well, but if we added an invalid regex, like [.*, to https://github.com/PyCQA/prospector/blob/master/tests/profiles/profiles/ignores.yaml, would that except clause be triggered with this test? https://github.com/PyCQA/prospector/blob/4e342e5c9971fcd66dccd065b341b7eb28202a89/tests/profiles/test_profile.py#L122-L124

Edit: Doing this does not hit that code path unfortunately.

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't release 1.8.3 without this.

@Pierre-Sassoulas Pierre-Sassoulas merged commit f315f54 into landscapeio:master Dec 8, 2022
@cclauss cclauss deleted the fix-re._constants branch December 8, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cclauss @gopackgo90 @Pierre-Sassoulas