Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pyroma dependency loop #574

Merged
merged 1 commit into from Jan 10, 2023
Merged

Fix pyroma dependency loop #574

merged 1 commit into from Jan 10, 2023

Conversation

sbrunner
Copy link
Contributor

@sbrunner sbrunner commented Jan 6, 2023 •
edited

Related Issue

#562

How Has This Been Tested?

pip install -e . # on prospector folder
prospector --output=pylint sphinx_prompt # on a project that use pyroma (witch failed before)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the dependencies
  • I have updated the dependencies accordingly
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Pierre-Sassoulas Pierre-Sassoulas added this to the 1.8.4 milestone Jan 6, 2023
@sbrunner sbrunner marked this pull request as ready for review January 6, 2023 12:31
@sbrunner
Copy link
Contributor Author

@Pierre-Sassoulas UP :-)

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminding me of this, LGTM.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 5ee46a8 into landscapeio:master Jan 10, 2023
@sbrunner
Copy link
Contributor Author

Thanks @Pierre-Sassoulas :-)

@sbrunner sbrunner deleted the fix-pyroma branch January 10, 2023 17:16
@LourensVeen LourensVeen mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.8.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbrunner @Pierre-Sassoulas