Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pep257 not running on prospector when run from the commandline #89

Closed
carlio opened this issue Jan 4, 2015 · 1 comment
Closed

pep257 not running on prospector when run from the commandline #89

carlio opened this issue Jan 4, 2015 · 1 comment

Comments

@carlio
Copy link
Member

carlio commented Jan 4, 2015

When running prospector on prospector using the .prospector.yml file, pep257 is not run for some reason.

Oddly, it works on Landscape.
carlio added a commit to carlio/prospector that referenced this issue Jan 4, 2015
@carlio
[refs landscapeio#89] Prospector-provided profiles should only be loa…
dbadcb5 
…ded if a profile was not provided by the user (or implicitly provided by having a .prospector.yml file)
@carlio
Copy link
Member Author

carlio commented Jan 4, 2015

I've tracked this down to a problem with inheritance (which is probably the same as #40). A user provided profile should override things it inherits from and so on, but that does not seem to always be the case. pep257 was not running because a parent profile, no_doc_warnings disabled it. It would run on some machines because the ordering of the profile inheritance was non-deterministic due to the deduplication using list(set(profiles)) which lost ordering.

carlio added a commit to carlio/prospector that referenced this issue Jan 5, 2015
@carlio
[refs landscapeio#89 landscapeio#40] Complete rewrite of how profiles…
f2a1683 
… are parsed and combined. This fixes problems with merging and introduces "shorthand" attributes, which are essentially user-friendly ways of inheriting the built-in prospector profiles
@carlio carlio mentioned this issue Jan 5, 2015
Merged
@carlio carlio closed this as completed Jan 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carlio