Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ignores in pyflakes. #105

Merged
merged 1 commit into from
Feb 10, 2015
Merged

Fixed ignores in pyflakes. #105

merged 1 commit into from
Feb 10, 2015

Conversation

jayclassless
Copy link
Contributor

Recent changes broke the ability to have pyflakes ignore codes via a profile. This small change fixes that.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.14% when pulling ac1157f on jayclassless:fix_pyflakes_ignores into f3df68f on landscapeio:master.

carlio added a commit that referenced this pull request Feb 10, 2015
@carlio carlio merged commit 4ed9396 into landscapeio:master Feb 10, 2015
@carlio
Copy link
Member

carlio commented Feb 10, 2015

Strange, I'm sure that I use ignoring directives for pyflakes in my own profiles! Could you share a stacktrace and python versions?

@jayclassless
Copy link
Contributor Author

There was no exception, it was just silently not working. It looked like the tuple comprehension was returning a generator that was exhausted the first time it was evaluated on line 67 (if code in self.ignore). Making it a normal list brought it back to a working state.

Python 2.7.5 on OSX

Here's an (edited) list of the stuff in my venv:
astroid==1.3.4
dodgy==0.1.6
logilab-common==0.63.2
mccabe==0.3
pep257==0.4.1
pep8==1.6.1
pep8-naming==0.2.2
prospector==0.9.9
pyflakes==0.8.1
pylint==1.4.1
pylint-celery==0.3
pylint-common==0.2.1
pylint-django==0.6
pylint-plugin-utils==0.2.3
pyroma==1.7
requirements-detector==0.3

@carlio
Copy link
Member

carlio commented Feb 10, 2015

Oh, I see, I've had that problem before. Sneaky generators. Thanks for the fix!

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.12% when pulling ac1157f on jayclassless:fix_pyflakes_ignores into f3df68f on landscapeio:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants