Support pylint 2.0 UnknownMessage rename to UnknownMessageError #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| from pylint.utils import UnknownMessage | ||
| except ImportError: | ||
| from pylint.utils import UnknownMessageError as UnknownMessage |
There was a problem hiding this comment.
According to https://docs.pylint.org/en/latest/whatsnew/changelog.html#what-s-new-in-pylint-1-7:
InvalidMessageError, UnknownMessage, and EmptyReport exceptions are moved to the new pylint.exceptions submodule.
So perhaps from pylint.exceptions import UnknownMessageError might be a better choice here.
|
What is the status on this? This error broke some of our CI jobs and this PR will fix it. |
|
Closing this PR in favor of #207. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pylint 2.0 switched to using UnknownMessageError (see commit).
This PR fixes this.