Fix missing 'UnknownMessage' exception #207
Conversation
The recent 1.7 version of pylint moved the exceptions to a different submodule and this ensures everything works as expected.
2 similar comments
There was a problem hiding this comment.
This looks good to me, thank you! Just left a minor comment in prospector/exceptions.py.
Adding a note to CHANGELOG.md may have increase the chance of this PR accepted faster (less work for maintainers)
I'm not a maintainer, but I think _INSTALL_REQUIRES should be updated in a feature release, not in a bugfix (or hotfix) release.
prospector/exceptions.py
Outdated
| @@ -1,5 +1,8 @@ | |||
| # -*- coding: utf-8 -*- | |||
|
|
|||
| try: | |||
There was a problem hiding this comment.
I'd add a comment explaining why this is here to help future reviewers.
There was a problem hiding this comment.
Good point. I'll put some comments in it.
|
@carlio Any feedback? I'd like to get this fixed. |
|
@sijis Hi apologies I am currently on holiday with minimal internet connection, will try to review and merge and release a new version today or tomorrow (PHT) |
|
Ok. Great! If there is anything you need adjusted let me know. |
|
Have you had an opportunity to review the PR? |
|
@sijis yes, finally also can upload a new package. Will do so in a few hours. Sorry it took so long. |
|
Thank you!! Totally fine that it took a while to get this in. Vacation/holiday is important. |
The recent 1.7 version of pylint moved the exceptions to a different
submodule and this ensures everything works as expected.
Since there's been no activity on #205, I took it upon myself to update it as suggested there.
I did end up moving the pylint exception to the
prospector.exceptionssubmodule, as I found it odd to sprinkle atry .. excepteverywhere.I did not update the
_INSTALL_REQUIRESinsetup.pyto up the version of pylint topylint>=1.7or so. I think it should probably be done too.This should also resolve #206.