Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set pylintrc inside prospector.yml #249

Merged
merged 2 commits into from
Jul 22, 2018

Conversation

chocoelho
Copy link
Contributor

@chocoelho chocoelho commented Apr 20, 2018

Fixes #231

As mentioned in the issue above, there's no way to set inside prospector.yml the path for pylintrc. Instead, users have to rely on either having the pylintrc (or similar) being inside the project folder or through the command line option --pylint-config-file which can be error prone.

With this change, users can set config_file inside pylint options on prospector.yml. it'll look like:

pylint:
  options:
    config_file: /home/xpto/projects/pylintrc
  disable:
    - bad-builtin
    - too-few-public-methods
    - missing-docstring
    - star-args

Also, if users set --pylint-config-file, it'll have priority over what was set inside prospector.yml.

@carlio carlio merged commit 2455f10 into landscapeio:develop Jul 22, 2018
@chocoelho chocoelho deleted the pylint-config branch July 24, 2018 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants