Fix read_config_file using quiet keyword with older pylint versions #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the previous change was implemented to allow the `config_from_file` method within the pylint tools to use the `quiet` keyword in older versions of pylint, the `quiet` keyword was added to the if block when the pylint version is 2.0 or greater instead of the else block for when the pylint version is less than (older) than 2.0
Pull Request Test Coverage Report for Build 610
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 610
💛 - Coveralls |
chocoelho
approved these changes
Jul 27, 2018
|
Thanks for the contribution @justke86 |
|
Hey guys - Great stuff. Any ideas when this will get merged into master? |
|
This introduces a bug when using pylint < 2.0 If you try to run prospector in python2 (ie: pylint 1.9) you cannot pass in --pylint-config-file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the previous change was implemented to allow the
config_from_filemethod within the pylint tools to use the
quietkeyword in olderversions of pylint, the
quietkeyword was added to the if block whenthe pylint version is 2.0 or greater instead of the else block for when
the pylint version is less than (older) than 2.0