Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with Frosted tool not handling ignores correctly. #28

Merged
merged 1 commit into from
Jun 10, 2014
Merged

Fixed issue with Frosted tool not handling ignores correctly. #28

merged 1 commit into from
Jun 10, 2014

Conversation

jayclassless
Copy link
Contributor

I guess I made the same stupid mistake when adding Frosted.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) when pulling 27e3bbf on jayclassless:frosted_ignored into 6ca1da1 on landscapeio:master.

@carlio
Copy link
Member

carlio commented Jun 10, 2014

I've done the same thing several times. There should probably be a common function for it!

carlio added a commit that referenced this pull request Jun 10, 2014
Fixed issue with Frosted tool not handling ignores correctly.
@carlio carlio merged commit f77574c into landscapeio:master Jun 10, 2014
@jayclassless
Copy link
Contributor Author

This probably aligns with #26, but I was thinking that prospector should have a centralized mechanism for crawling the project, finding files to inspect, and applying all the ignore/include/exclude logic, and then it could feed the file list to each of the tools from there. This would be instead of having each tool implement this logic on its own.

If we can centralize this sort of functionality, then we could also just parse the AST for a given file once, rather than having each tool parse the AST. It should make things quicker, especially for bigger projects.

@carlio
Copy link
Member

carlio commented Jun 16, 2014

Agreed, especially on the speedup. My main concern is that often the other tools don't expose their internal API neatly, so it may be tricky to pass in an AST and may introduce breaking changes between their versions. I'd still like to investigate it a bit more, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants