Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output path tests and abspaths for windows #299

Merged
merged 3 commits into from
Nov 29, 2018
Merged

Output path tests and abspaths for windows #299

merged 3 commits into from
Nov 29, 2018

Conversation

djpugh
Copy link
Contributor

@djpugh djpugh commented Nov 22, 2018

Add fix for windows abspath handling
Fixes #298

@djpugh
Copy link
Contributor Author

djpugh commented Nov 22, 2018 •
edited
Loading

Need to patch path.sep and path.altsep for the tests for windows as well

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 77.979% when pulling 9bef379 on djpugh:output_path_tests into 79587c5 on PyCQA:master.

@carlio carlio changed the base branch from master to develop November 29, 2018 05:24
@carlio carlio merged commit 5ec68ae into landscapeio:develop Nov 29, 2018
@carlio
Copy link
Member

carlio commented Nov 29, 2018

Merged into 'develop' ('master' should be === latest pypi release) but this will go out next release. Thanks :-D

@djpugh djpugh mentioned this pull request Dec 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djpugh @coveralls @carlio