Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for node_modules and __pycache__ in path to ignore in FoundFiles #344

Merged

Conversation

chocoelho
Copy link
Contributor

Description

I added some checkage for both node_modules and __pycache__ directories as both of them shouldn't be taken into consideration for FoundFiles. Also, a proposal of Dockerfile to easier the setup for contribution is present in this PR.

Related Issue

#328

Motivation and Context

node_modules can be really huge and is of no interest to prospector, the same can be said about __pycache__ directories. They can increase unnecessary running time and should be removed from consideration. Also, it'd be good to consider whether it's a proper time to take into consideration VCS ignore files.

How Has This Been Tested?

I've tested it in a clean container using Python 3.6 and tested for node_modules presence in found files, could also add tests for __pycache__, but since it's pretty similar to node_modules checkage, it'd only be redundant to add this as it'll only mean an increase in coverage percentage.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the dependencies
  • I have updated the dependencies accordingly
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@chocoelho chocoelho requested a review from carlio July 31, 2019 23:27
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 76.694% when pulling f38868e on vintasoftware:ft-ignore-node_modules-path into a8c5273 on PyCQA:develop.

@chocoelho chocoelho merged commit a59ee83 into landscapeio:develop Aug 14, 2019
@chocoelho chocoelho deleted the ft-ignore-node_modules-path branch August 14, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants