Check for node_modules and __pycache__ in path to ignore in FoundFiles #344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added some checkage for both
node_modules
and__pycache__
directories as both of them shouldn't be taken into consideration for FoundFiles. Also, a proposal of Dockerfile to easier the setup for contribution is present in this PR.Related Issue
#328
Motivation and Context
node_modules
can be really huge and is of no interest to prospector, the same can be said about__pycache__
directories. They can increase unnecessary running time and should be removed from consideration. Also, it'd be good to consider whether it's a proper time to take into consideration VCS ignore files.How Has This Been Tested?
I've tested it in a clean container using Python 3.6 and tested for
node_modules
presence in found files, could also add tests for__pycache__
, but since it's pretty similar tonode_modules
checkage, it'd only be redundant to add this as it'll only mean an increase in coverage percentage.Types of changes
Checklist: