Mypy 730 compat #355
Merged
Mypy 730 compat #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mypy now adds a summary as the last line of the output. Pass a flag to not add this symmary. Previous versions of mypy ignore this flag. fix landscapeio#345
chocoelho
approved these changes
Nov 21, 2019
|
Thanks @rik. I should release a new dev version EOD with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous patch does not work because of this silly change I did after testing…
Somehow, I missed the
--no-error-summaryflag the first time I read #345. Thanks @ziyadedher for finding this!Therefore, this PR reverts my previous attempt and passes one more flag.
I've tested this on mypy 0.720: it correctly ignores this flag. And it works with 0.740.