Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.8 #356

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

Dunedan
Copy link
Contributor

@Dunedan Dunedan commented Nov 20, 2019

This should fix failures with pyflakes (#353) and pylint when running prospector with Python 3.8 and marks Python 3.8 as supported by prospector.

Related Issue

#353

How Has This Been Tested?

Aside from running the included tests with Python 3.8 I ran prospector against a large proprietary project which had pylint and pyflakes failing previously when running with Python 3.8.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the dependencies
  • I have updated the dependencies accordingly
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

coveralls commented Nov 20, 2019

Coverage Status

Coverage increased (+0.7%) to 74.135% when pulling 8309841 on conhealth:python3.8-support into 00a33d9 on PyCQA:develop.

@chocoelho
Copy link
Contributor

Thanks for the contribution @Dunedan, I should release a new dev version so with this so we others can benefit from it before our next stable release

@chocoelho chocoelho merged commit 77823fc into landscapeio:develop Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants