Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fatal error on running mypy when duplicate module names #399

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

sbrunner
Copy link
Contributor

@sbrunner sbrunner commented Dec 30, 2020

Description

Fix #350

Related Issue

#350

Motivation and Context

How Has This Been Tested?

Run prospector -X admin/setup.py geoportal/setup.py where admin and geoportal are standalone packages =>

Messages
========

geoportal/setup.py
  Line: 0
    mypy: error / Duplicate module named 'setup' (also at '/home/sbrunner/workspace/c2cgeoportal/admin/setup.py')


Check Information
=================
         Started: 2020-12-30 14:37:27.374357
        Finished: 2020-12-30 14:37:28.200837
      Time Taken: 0.83 seconds
       Formatter: grouped
        Profiles: .prospector.yaml, strictness_veryhigh, no_doc_warnings, no_member_warnings, no_test_warnings
      Strictness: from profile
  Libraries Used: 
       Tools Run: dodgy, mypy, pep8, profile-validator, pyflakes, pylint
  Messages Found: 1
 External Config: pep8: Configuration found at /home/sbrunner/workspace/c2cgeoportal/setup.cfg, pylint: /home/sbrunner/workspace/c2cgeoportal/.pylintrc

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the dependencies
  • I have updated the dependencies accordingly
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

coveralls commented Dec 30, 2020

Coverage Status

Coverage increased (+0.06%) to 82.132% when pulling 3dc8a39 on sbrunner:fix-mypy into 9a8c0e3 on PyCQA:master.

@sbrunner sbrunner force-pushed the fix-mypy branch 3 times, most recently from 7808dcd to 26d6d93 Compare December 30, 2020 14:31
@sbrunner sbrunner marked this pull request as ready for review December 30, 2020 14:40
@sbrunner sbrunner changed the base branch from master to develop April 27, 2021 08:33
@sbrunner sbrunner changed the base branch from develop to master August 27, 2021 10:05
@sbrunner
Copy link
Contributor Author

@Pierre-Sassoulas can you have a look at this pull request?
It's relay annoying to have a hidden error...

@Pierre-Sassoulas
Copy link
Collaborator

Closed reopened in order to fix the stuck check.

Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thank you.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 4da6a19 into landscapeio:master Aug 27, 2021
@sbrunner
Copy link
Contributor Author

Thanks @Pierre-Sassoulas

@sbrunner sbrunner deleted the fix-mypy branch August 28, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to run mypy when duplicate module names
3 participants