Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unclosed file warning #412

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Conversation

ckleemann
Copy link
Contributor

Description

Fix the unclosed file handle warning by using an context-manager for each open file.

Related Issue

#411

Motivation and Context

It fixes the unclosed file warning for each file analyzed.

How Has This Been Tested?

I let run the tox tests as well as the nosetests. Also I checked with a project of mine if the warning disappeared.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the dependencies
  • I have updated the dependencies accordingly
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 9d1ecfd into landscapeio:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants