Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urls in comments #326

Closed
twmr opened this issue Sep 13, 2014 · 6 comments
Closed

urls in comments #326

twmr opened this issue Sep 13, 2014 · 6 comments

Comments

@twmr
Copy link

twmr commented Sep 13, 2014

the line length check should be skipped if the line contains a long url

(see matplotlib/matplotlib#3507 (comment))

@sigmavirus24
Copy link
Member

@thisch I'm not following. That discussion explains that it does skip it. What problem are you seeing and on what version of pep8?

@twmr
Copy link
Author

twmr commented Sep 13, 2014

see matplotlib/matplotlib#3507 (comment)

we want that if a comment contains an url, whose length is larger than the max line length, it should not yield E501

@tacaswell
Copy link

The line has to start with the url which seems like a reasonable constraint on long urls.

@thisch Move the discussion here.

@twmr
Copy link
Author

twmr commented Sep 13, 2014

Yes if the line starts with the url it does not yield E501. I'm fine with that -> Closing

@twmr twmr closed this as completed Sep 13, 2014
@sigmavirus24
Copy link
Member

@thisch in the future, if you report an issue please provide more than a link. Please provide exactly what is needed to reproduce what you are claiming is a bug. Thanks @tacaswell for helping clarify this for @thisch

@twmr
Copy link
Author

twmr commented Sep 13, 2014

Sry about that, I'll try to provide more details the next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants