No warning about missing space between closing parenthesis and keyword

[dpursehouse]

The following code does not result in any warnings:

if a()and b():
    pass

if b()in [1, 2, 3]:
    pass

if c()or d():
    pass

[methane]

Missing space between keyword and opening parenthesis doesn't raise warning too.

if(1 == 0):
    pass

[OswinNathanial]

The following does not raise any warnings:

x = a-b

where as the following does:

x = a -b

x = a- b

[sigmavirus24]

What versions of pep8 are all of you using?

[OswinNathanial]

The problem I mentioned exists in version 1.6.2

[jayvdb]

@OswinNathanial , pep8 is very clear about consistent spacing around operators, but is lax about one versus zero spaces.

"If operators with different priorities are used, consider adding whitespace around the operators with the lowest priority(ies). Use your own judgment; however, never use more than one space, and always have the same amount of whitespace on both sides of a binary operator."

@methane, your case is not covered by the above, and I cant find anything explicitly rejecting that syntax in pep8. I've forked that off to be #570, as it is a bit of a mine field of vague and unspecified implied styles.

Regarding the original issue, pep8 guideline is very clear about spaces around in and or:

"Always surround these binary operators with a single space on either side: assignment ( = ), augmented assignment ( += , -= etc.), comparisons ( == , < , > , != , <> , <= , >= , in , not in , is , is not ), Booleans ( and , or , not ). "

And I can confirm that is not checked in the latest pycodestyle.

[asottile]

#631 includes another few cases for this:

[(a,)for a in y]

from .import bar

try:
    ...
except(IOError,):
    ...

[asottile]

#570 also contains some cases for this as well with if(...)

[asottile]

#646 also includes some cases for in(...) and or(...)

[asottile]

#650 also mentions return(...) / return[...]

[asottile]

#843 points out these oddities as well (which are enough to confuse github's parser!):

0and 1
0x1or 0

[jpmckinney]

Noting that in 2.9.0, code like a, b, c = (yield) now complains about there not being a space after yield. I just removed the parentheses as they serve no purpose, but it's weird that I should have to write (yield ) if I wanted to preserve them.

[asottile]

@jpmckinney please open a new issue with a full code sample and output and we can fix it. there are cases iirc where yield does need parenthesizing and we should make sure those are handled properly -- a small oversight while implementing this

[jpmckinney]

Thanks, @asottile. I've opened #1090.