Fixes some issues with E741 detection #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rettenbs
changed the title
Closed
timokau
added a commit
to timokau/cs-ranking
that referenced
this pull request
Apr 2, 2020
Currently this violates flake8/pycodestyle E741. Arguably that shouldn't be the case [1] since we don't control the API. This has recently been fixed upstream [2], but isn't released yet. Luckily our use is trivial. The function only takes one argument, so the named parameter does't really add any value. We can just remove it. [1] PyCQA/pycodestyle#700 [2] PyCQA/pycodestyle#853
timokau
added a commit
to timokau/cs-ranking
that referenced
this pull request
Apr 3, 2020
Currently this violates flake8/pycodestyle E741. Arguably that shouldn't be the case [1] since we don't control the API. This has recently been fixed upstream [2], but isn't released yet. Luckily our use is trivial. The function only takes one argument, so the named parameter does't really add any value. We can just remove it. [1] PyCQA/pycodestyle#700 [2] PyCQA/pycodestyle#853
mihaic
added a commit
to mihaic/brainiak
that referenced
this pull request
May 20, 2020
The renames do not affect the API, except for `concatenate_not_none`, where the rename actually makes the code agree to the existing documentation. The existing variable names caused errors after an update of Pycodestyle in Flake8: brainiak#464 PyCQA/pycodestyle#853 https://gitlab.com/pycqa/flake8/-/merge_requests/418
mihaic
added a commit
to brainiak/brainiak
that referenced
this pull request
May 21, 2020
The renames do not affect the API, except for `concatenate_not_none`, where the rename actually makes the code agree to the existing documentation. The existing variable names caused errors after an update of Pycodestyle in Flake8: #464 PyCQA/pycodestyle#853 https://gitlab.com/pycqa/flake8/-/merge_requests/418 Also add a workaround for a Theano compilation error, inspired by PyMC3: pymc-devs/pymc#3767
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #707
Closes #700