Support visual indent of continuation lines after with/assert/raise. #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Feb 25, 2020
| print('foo') | ||
| with open('/path/to/some/file/you/want/to/read') as file_1, \ | ||
| open('/path/to/some/file/being/written', 'w') as file_2: | ||
| file_2.write(file_1.read()) |
There was a problem hiding this comment.
none of these three align properly -- they should produce an error I believe?
There was a problem hiding this comment.
they do.
not sure I understand the syntax of the test file actually... I added #: E127:4:... and looks like tests pass
(the error is produced when manually testing as well)
There was a problem hiding this comment.
😕 weird! I'll look into why that is and fix that up 👍
|
Does it work for more than one line continuation as well? |
"with" is likely the most common case, and this indentation is explicitly given as example by PEP8 (under "maximum line length").
|
Yes, added tests for that. |
This was referenced Jun 14, 2020
Closed
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"with" is likely the most common case, and this indentation is
explicitly given as example by PEP8 (under "maximum line length").
Closes #569.