Skip to content

Commit

Permalink
Update to new astroid node names
Browse files Browse the repository at this point in the history
these have been deprecated in astroid 1.4.0 and removed in 2.0
  • Loading branch information
atodorov committed Jul 16, 2018
1 parent 50eb327 commit 5b8e006
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions pylint_django/augmentations/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -754,8 +754,8 @@ def apply_augmentations(linter):
# forms implement __getitem__ but not __len__, thus raising a "Badly implemented container" warning which
# we will suppress. NOTE: removed from pylint, https://github.com/PyCQA/pylint/issues/112
# keeping here in case it gets re-implemented
# suppress_message(linter, _leave_class(MisdesignChecker), 'R0924', is_class('django.forms.forms.Form'))
# suppress_message(linter, _leave_class(MisdesignChecker), 'R0924', is_class('django.forms.models.ModelForm'))
# suppress_message(linter, _leave_classdef(MisdesignChecker), 'R0924', is_class('django.forms.forms.Form'))
# suppress_message(linter, _leave_classdef(MisdesignChecker), 'R0924', is_class('django.forms.models.ModelForm'))

# Meta
suppress_message(linter, DocStringChecker.visit_classdef, 'missing-docstring', is_model_meta_subclass)
Expand Down
2 changes: 1 addition & 1 deletion pylint_django/transforms/fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,4 @@ def apply_type_shim(cls, _context=None): # noqa


def add_transforms(manager):
manager.register_transform(nodes.Class, inference_tip(apply_type_shim), is_model_or_form_field)
manager.register_transform(nodes.ClassDef, inference_tip(apply_type_shim), is_model_or_form_field)
4 changes: 2 additions & 2 deletions pylint_django/transforms/foreignkey.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def infer_key_classes(node, context=None):
for arg in node.args:
# typically the class of the foreign key will
# be the first argument, so we'll go from left to right
if isinstance(arg, (nodes.Name, nodes.Getattr)):
if isinstance(arg, (nodes.Name, nodes.Attributes)):
try:
key_cls = None
for inferred in arg.infer(context=context):
Expand Down Expand Up @@ -56,5 +56,5 @@ def infer_key_classes(node, context=None):


def add_transform(manager):
manager.register_transform(nodes.CallFunc, inference_tip(infer_key_classes),
manager.register_transform(nodes.Call, inference_tip(infer_key_classes),
is_foreignkey_in_class)

0 comments on commit 5b8e006

Please sign in to comment.