Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make wheel take in account files in Manifest.ini #135

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Make wheel take in account files in Manifest.ini #135

merged 1 commit into from
Mar 7, 2018

Conversation

aerostitch
Copy link
Contributor

@aerostitch aerostitch commented Mar 7, 2018 •
edited

This fixes the current issue of includes from MANIFEST.ini not included in wheel dist. It should also fix the issue with pip.

Before the fix:

$ unzip -t /tmp/wheelhouse/pylint_django-0.9.2-py3-none-any.whl
Archive:  /tmp/wheelhouse/pylint_django-0.9.2-py3-none-any.whl
    testing: pylint_django/__init__.py   OK
    testing: pylint_django/__pkginfo__.py   OK
    testing: pylint_django/compat.py   OK
    testing: pylint_django/plugin.py   OK
    testing: pylint_django/utils.py   OK
    testing: pylint_django/augmentations/__init__.py   OK
    testing: pylint_django/checkers/__init__.py   OK
    testing: pylint_django/checkers/django_installed.py   OK
    testing: pylint_django/checkers/models.py   OK
    testing: pylint_django/tests/__init__.py   OK
    testing: pylint_django/tests/test_func.py   OK
    testing: pylint_django/tests/input/__init__.py   OK
    testing: pylint_django/tests/input/external_django_tables2_noerror_meta_class.py   OK
    testing: pylint_django/tests/input/external_drf_noerror_serializer.py   OK
    testing: pylint_django/tests/input/external_psycopg2_noerror_postgres_fields.py   OK
    testing: pylint_django/tests/input/func_model_does_not_use_unicode_py33.py   OK
    testing: pylint_django/tests/input/func_noerror_classviews.py   OK
    testing: pylint_django/tests/input/func_noerror_duplicate_except_doesnotexist.py   OK
    testing: pylint_django/tests/input/func_noerror_foreign_key_attributes.py   OK
    testing: pylint_django/tests/input/func_noerror_foreign_key_ids.py   OK
    testing: pylint_django/tests/input/func_noerror_foreign_key_sets.py   OK
    testing: pylint_django/tests/input/func_noerror_foreignkeys.py   OK
    testing: pylint_django/tests/input/func_noerror_form_fields.py   OK
    testing: pylint_django/tests/input/func_noerror_forms_py33.py   OK
    testing: pylint_django/tests/input/func_noerror_formview_ancestors.py   OK
    testing: pylint_django/tests/input/func_noerror_ignore_meta_subclass.py   OK
    testing: pylint_django/tests/input/func_noerror_import_q.py   OK
    testing: pylint_django/tests/input/func_noerror_issue_46.py   OK
    testing: pylint_django/tests/input/func_noerror_manytomanyfield.py   OK
    testing: pylint_django/tests/input/func_noerror_model_fields.py   OK
    testing: pylint_django/tests/input/func_noerror_model_methods.py   OK
    testing: pylint_django/tests/input/func_noerror_model_unicode_callable.py   OK
    testing: pylint_django/tests/input/func_noerror_model_unicode_lambda.py   OK
    testing: pylint_django/tests/input/func_noerror_models_py33.py   OK
    testing: pylint_django/tests/input/func_noerror_protected_meta_access.py   OK
    testing: pylint_django/tests/input/func_noerror_ugettext_lazy_format.py   OK
    testing: pylint_django/tests/input/func_noerror_unicode_py2_compatible.py   OK
    testing: pylint_django/tests/input/func_noerror_urls.py   OK
    testing: pylint_django/tests/input/func_noerror_uuid_field.py   OK
    testing: pylint_django/transforms/__init__.py   OK
    testing: pylint_django/transforms/fields.py   OK
    testing: pylint_django/transforms/foreignkey.py   OK
    testing: pylint_django-0.9.2.dist-info/DESCRIPTION.rst   OK
    testing: pylint_django-0.9.2.dist-info/metadata.json   OK
    testing: pylint_django-0.9.2.dist-info/top_level.txt   OK
    testing: pylint_django-0.9.2.dist-info/WHEEL   OK
    testing: pylint_django-0.9.2.dist-info/METADATA   OK
    testing: pylint_django-0.9.2.dist-info/RECORD   OK
No errors detected in compressed data of /tmp/wheelhouse/pylint_django-0.9.2-py3-none-any.whl.

After the fix:

$ unzip -t /tmp/wheelhouse/pylint_django-0.9.2-py3-none-any.whl
Archive:  /tmp/wheelhouse/pylint_django-0.9.2-py3-none-any.whl
    testing: pylint_django/__init__.py   OK                                   
    testing: pylint_django/__pkginfo__.py   OK                            
    testing: pylint_django/compat.py   OK                                       
    testing: pylint_django/plugin.py   OK                   
    testing: pylint_django/utils.py   OK                                       
    testing: pylint_django/augmentations/__init__.py   OK         
    testing: pylint_django/checkers/__init__.py   OK                                          
    testing: pylint_django/checkers/django_installed.py   OK
    testing: pylint_django/checkers/models.py   OK
    testing: pylint_django/tests/__init__.py   OK
    testing: pylint_django/tests/test_func.py   OK
    testing: pylint_django/tests/input/__init__.py   OK
    testing: pylint_django/tests/input/external_django_tables2_noerror_meta_class.py   OK
    testing: pylint_django/tests/input/external_drf_noerror_serializer.py   OK
    testing: pylint_django/tests/input/external_drf_noerror_serializer.rc   OK
    testing: pylint_django/tests/input/external_psycopg2_noerror_postgres_fields.py   OK
    testing: pylint_django/tests/input/external_psycopg2_noerror_postgres_fields.rc   OK
    testing: pylint_django/tests/input/func_model_does_not_use_unicode_py33.py   OK
    testing: pylint_django/tests/input/func_model_does_not_use_unicode_py33.txt   OK
    testing: pylint_django/tests/input/func_noerror_classviews.py   OK
    testing: pylint_django/tests/input/func_noerror_duplicate_except_doesnotexist.py   OK
    testing: pylint_django/tests/input/func_noerror_foreign_key_attributes.py   OK
    testing: pylint_django/tests/input/func_noerror_foreign_key_ids.py   OK
    testing: pylint_django/tests/input/func_noerror_foreign_key_sets.py   OK
    testing: pylint_django/tests/input/func_noerror_foreignkeys.py   OK
    testing: pylint_django/tests/input/func_noerror_form_fields.py   OK
    testing: pylint_django/tests/input/func_noerror_forms_py33.py   OK
    testing: pylint_django/tests/input/func_noerror_formview_ancestors.py   OK
    testing: pylint_django/tests/input/func_noerror_ignore_meta_subclass.py   OK
    testing: pylint_django/tests/input/func_noerror_import_q.py   OK
    testing: pylint_django/tests/input/func_noerror_issue_46.py   OK
    testing: pylint_django/tests/input/func_noerror_manytomanyfield.py   OK
    testing: pylint_django/tests/input/func_noerror_model_fields.py   OK
    testing: pylint_django/tests/input/func_noerror_model_methods.py   OK
    testing: pylint_django/tests/input/func_noerror_model_unicode_callable.py   OK
    testing: pylint_django/tests/input/func_noerror_model_unicode_lambda.py   OK
    testing: pylint_django/tests/input/func_noerror_models_py33.py   OK
    testing: pylint_django/tests/input/func_noerror_protected_meta_access.py   OK
    testing: pylint_django/tests/input/func_noerror_ugettext_lazy_format.py   OK
    testing: pylint_django/tests/input/func_noerror_unicode_py2_compatible.py   OK
    testing: pylint_django/tests/input/func_noerror_urls.py   OK
    testing: pylint_django/tests/input/func_noerror_uuid_field.py   OK
    testing: pylint_django/transforms/__init__.py   OK
    testing: pylint_django/transforms/fields.py   OK
    testing: pylint_django/transforms/foreignkey.py   OK
    testing: pylint_django/transforms/transforms/django_contrib_postgres_fields.py   OK
    testing: pylint_django/transforms/transforms/django_core_handlers_wsgi.py   OK
    testing: pylint_django/transforms/transforms/django_db_models.py   OK
    testing: pylint_django/transforms/transforms/django_db_models_fields.py   OK
    testing: pylint_django/transforms/transforms/django_db_models_fields_files.py   OK
    testing: pylint_django/transforms/transforms/django_forms.py   OK
    testing: pylint_django/transforms/transforms/django_forms_fields.py   OK
    testing: pylint_django/transforms/transforms/django_utils_translation.py   OK
    testing: pylint_django/transforms/transforms/django_views_generic_base.py   OK
    testing: pylint_django/transforms/transforms/mongoengine.py   OK
    testing: pylint_django-0.9.2.dist-info/DESCRIPTION.rst   OK
    testing: pylint_django-0.9.2.dist-info/metadata.json   OK
    testing: pylint_django-0.9.2.dist-info/top_level.txt   OK
    testing: pylint_django-0.9.2.dist-info/WHEEL   OK
    testing: pylint_django-0.9.2.dist-info/METADATA   OK
    testing: pylint_django-0.9.2.dist-info/RECORD   OK
No errors detected in compressed data of /tmp/wheelhouse/pylint_django-0.9.2-py3-none-any.whl.

Closes #133
Closes #134

@aerostitch
Copy link
Contributor Author

@atodorov @vCra let me know if that fixes your issue entirely. Thanks! :)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 297

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 84.826%
Files with Coverage Reduction New Missed Lines %
pylint_django/transforms/fields.py 1 98.11%
Totals Coverage Status
Change from base Build 295: 0.0%
Covered Lines: 464
Relevant Lines: 547
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Mar 7, 2018 •
edited

Pull Request Test Coverage Report for Build 297

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 84.826%
Files with Coverage Reduction New Missed Lines %
pylint_django/transforms/fields.py 1 98.11%
Totals Coverage Status
Change from base Build 295: 0.0%
Covered Lines: 464
Relevant Lines: 547
💛 - Coveralls

@atodorov atodorov merged commit a33f52d into pylint-dev:master Mar 7, 2018
@atodorov
Copy link
Contributor

atodorov commented Mar 7, 2018

@aerostitch thanks a lot. Merged and pushed 0.9.3. From what I can tell this solves the problem.

I've also opened a task for myself to make sure I add some more tests around the release process so this never happens again.

@aerostitch aerostitch deleted the fix_9.2 branch March 7, 2018 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pip is not installing files in transforms/transforms Difference in wheel and tar.gz packages
3 participants
@aerostitch @coveralls @atodorov