Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 and pylint fixes #138

Merged
merged 5 commits into from
Mar 16, 2018
Merged

Flake8 and pylint fixes #138

merged 5 commits into from
Mar 16, 2018

Conversation

atodorov
Copy link
Contributor

There are still a few pylint issues to be resolved, mostly TODO and fix me items.

this is for versions which are several years old and pylint-django
requires a relatively new pylint, which probably pulls in latest
astroid.

I'm not adding a versioned dependency for astroid. If anyone
reports a bug for that we can add the dependency and tell them to
upgrade!
we're down to mostly fix me and TODO items
@atodorov atodorov requested a review from carlio March 14, 2018 14:17
@atodorov atodorov self-assigned this Mar 14, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 325

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 85.389%

Totals Coverage Status
Change from base Build 321: 0.8%
Covered Lines: 450
Relevant Lines: 527

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Mar 14, 2018

Pull Request Test Coverage Report for Build 325

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 85.389%

Totals Coverage Status
Change from base Build 321: 0.8%
Covered Lines: 450
Relevant Lines: 527

💛 - Coveralls

@atodorov atodorov merged commit c785380 into master Mar 16, 2018
@atodorov atodorov deleted the flake8_fixes branch March 16, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants