Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint output is too verbose #1853

Closed
cdyson37 opened this issue Jan 25, 2018 · 12 comments
Closed

Pylint output is too verbose #1853

cdyson37 opened this issue Jan 25, 2018 · 12 comments
Labels
Enhancement ✨ Improvement to a component Good first issue Friendly and approachable by new contributors

Comments

@cdyson37
Copy link

In particular. since at least 1.8.1, it now prints the location of the config file on every invocation. This results in a lot of spam if you use a parallel build/test system.

It would be good to have an option to emit not output unless there are warnings. Silence is golden :) In fact I think things like the location of the config should only be printed if the user requests additional verbosity.

@dstromberg
Copy link

dstromberg commented Jan 25, 2018 via email

@PCManticore
Copy link
Contributor

Sounds like a good idea, we can definitely silence this message unless a verbose option is given.

@Jitsusama
Copy link

@PCManticore; I was curious if any work was planned around this? When integrating pylint into my CD life-cycle, I'm getting a tonne of spurious logs while it validates code style.

@dstromberg
Copy link

dstromberg commented Apr 9, 2018 via email

@PCManticore
Copy link
Contributor

No work has been planned, feel free to submit a PR if you have some time!

@Jitsusama
Copy link

@PCManticore; I haven't dug into pylint's code-base yet. Do you have any recommended area of this code-base to start looking at if I were to introduce this feature/change myself?

@PCManticore
Copy link
Contributor

@Jitsusama You might look into config.py, where this log actually happens. The flag can be added to lint.py, more exactly in the Run class, after which it can be propagated into the config. We already have a parameter for quiet here (https://github.com/PyCQA/pylint/blob/975e08148c0faa79958b459303c47be1a2e1500a/pylint/config.py#L463), but needs to be passed down as an option from the CLI. Let me know if you need any help!

@Jitsusama
Copy link

Thanks @PCManticore, I'll take a look at that!

@Jitsusama
Copy link

@PCManticore; just to verify, is your preference still to silence by default and only present when pylint is in verbose mode as per #1853 (comment)?

@Jitsusama
Copy link

@PCManticore; just bumping this thread as I didn't get a reply to my last question.

@PCManticore
Copy link
Contributor

@Jitsusama yes.

@AWhetter AWhetter added the Good first issue Friendly and approachable by new contributors label May 10, 2018
@PCManticore
Copy link
Contributor

A verbose mode was added recently in the master branch. You can now enable various verbose messages with pylint -v.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Improvement to a component Good first issue Friendly and approachable by new contributors
Projects
None yet
Development

No branches or pull requests

5 participants