Guarantee that abstract method prototype equals override prototype

[roelvandergoot]

Is your feature request related to a problem? Please describe

No.

Describe the solution you'd like

Create file "featreq.py"

"""Module doc string."""

from abc import abstractmethod


class Base:
    """Base doc string."""
    # pylint: disable=too-few-public-methods

    @abstractmethod
    async def func(self, arg):
        """func doc string."""


class Derived(Base):
    """Derived doc string."""
    # pylint: disable=too-few-public-methods

    def func(self, arg):
        return arg

Currently, pylint featreq.py produces:

------------------------------------
Your code has been rated at 10.00/10

What I would like:

featreq.py:19:4: W0000: Method differs from overridden 'func' method

Additional context

Note the additional "async" in method Base.func, or the missing "async" in method Derived.func.
Of course, the reverse, a missing "async" in method Base.func and an additional "async" in method Derived.func should also produce a warning.

[PCManticore]

Thanks for the report! This would be an useful check.

[craig-sh]

Hi, I'd like to work on this issue.

Would it make more sense to have W0236: invalid-overridden-method include this case or to just create a new warning message? Currently invalid-overridden-method is specific to property checks.

EDIT: Submitted a PR that uses a new warning: invalid-overridden-coroutine

[roelvandergoot]

Thank you!

…

On Wed, Feb 12, 2020, 00:54 Claudiu Popa ***@***.***> wrote: Closed #3355 <#3355> via #3392 <#3392>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3355>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKRYJRM733KDYJTRKGQP6RDRCOTKLANCNFSM4KIXITMA> .