New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make undefined-variable
flag type annotation without value assignment
#5158
Merged
DanielNoord
merged 3 commits into
pylint-dev:main
from
DanielNoord:undefined-variable-type
Oct 15, 2021
Merged
Make undefined-variable
flag type annotation without value assignment
#5158
DanielNoord
merged 3 commits into
pylint-dev:main
from
DanielNoord:undefined-variable-type
Oct 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
the
False Negative 🦋
No message is emitted but something is wrong with the code
label
Oct 15, 2021
Pull Request Test Coverage Report for Build 1345355352
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ! I have a nitpick :)
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
DanielNoord
commented
Oct 15, 2021
Pierre-Sassoulas
approved these changes
Oct 15, 2021
This change causes a crash when testing Home Assistant.
To reproduce # pylint: disable=undefined-variable
def _purge_filtered_states(session) -> None:
"""Remove filtered states and linked events."""
state_ids: list[int]
event_ids: list[int | None]
state_ids, event_ids = zip(
*(
session.query(States.state_id, States.event_id)
.filter(States.entity_id.in_(excluded_entity_ids))
.limit(MAX_ROWS_TO_PURGE)
.all()
)
)
event_ids = [id_ for id_ in event_ids if id_ is not None] -- |
Tracking the issue in #5162 |
cdce8p
added a commit
to cdce8p/pylint
that referenced
this pull request
Oct 16, 2021
…e assignment (pylint-dev#5158)" This reverts commit b1c4735.
cdce8p
added a commit
to cdce8p/pylint
that referenced
this pull request
Oct 17, 2021
…e assignment (pylint-dev#5158)" This reverts commit b1c4735.
cdce8p
added a commit
to cdce8p/pylint
that referenced
this pull request
Oct 17, 2021
…e assignment (pylint-dev#5158)" This reverts commit b1c4735.
cdce8p
added a commit
to cdce8p/pylint
that referenced
this pull request
Oct 21, 2021
…e assignment (pylint-dev#5158)" This reverts commit b1c4735.
cdce8p
added a commit
to cdce8p/pylint
that referenced
this pull request
Oct 21, 2021
…e assignment (pylint-dev#5158)" This reverts commit b1c4735.
cdce8p
added a commit
to cdce8p/pylint
that referenced
this pull request
Oct 23, 2021
…e assignment (pylint-dev#5158)" This reverts commit b1c4735.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/whatsnew/<current release.rst>
.Type of Changes
Description
Closes #5140