Add flake8 bugbear to pre-commit

[Pierre-Sassoulas]

Type of Changes

	Type
✓	🔨 Refactoring

Description

I realized that flake8-bugbear was configured in astroid but not pylint when upgrading pre-commit. Generally it's the other way around. There were some fixes to do, some of them valuable.

[coveralls]

Pull Request Test Coverage Report for Build 3372880403

• 9 of 9 (100.0%) changed or added relevant lines in 6 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.001%) to 95.38%

---

Totals
Change from base Build 3367355028:	-0.001%
Covered Lines:	17237
Relevant Lines:	18072

---

💛 - Coveralls

[DanielNoord]

What's the warning here?

[Pierre-Sassoulas]

'Loop control variable overrides iterable it iterates' (It's by design)

[DanielNoord]

Are you sure? Can't for line be for index?
The iterable value just seems to be a integer that's called line.

[Pierre-Sassoulas]

I'd rather not touch this, my goal is to add flake8 bugbear not "fix" all legacy issues (especially when the fix is not trivial and the code is working well).

[Pierre-Sassoulas]

I don't have the time to fix everything, could we merge with the current disable so flake8 bugbear is applied on new code and the already working code stay as is ? In particular fixing dummy-variables-rgx seems 4 hours of work or more. Polishing working code we don't understand well means we can introduce bugs that we'll have to fix later.

[github-actions]

🤖 Effect of this PR on checked open source code: 🤖

Effect on pytest:
The following messages are now emitted:

1. inconsistent-return-statements:
   Either all return statements in a function should return an expression, or none of them should.
   https://github.com/pytest-dev/pytest/blob/50b232b0cb39490776da2658ae69c669ce263050/src/_pytest/pytester.py#L301
2. no-name-in-module:
   No name 'NOSE_SUPPORT_METHOD' in module '_pytest.deprecated'
   https://github.com/pytest-dev/pytest/blob/50b232b0cb39490776da2658ae69c669ce263050/src/_pytest/python.py#L62
3. no-name-in-module:
   No name 'PytestReturnNotNoneWarning' in module '_pytest.warning_types'
   https://github.com/pytest-dev/pytest/blob/50b232b0cb39490776da2658ae69c669ce263050/src/_pytest/python.py#L81
4. inconsistent-return-statements:
   Either all return statements in a function should return an expression, or none of them should.
   https://github.com/pytest-dev/pytest/blob/50b232b0cb39490776da2658ae69c669ce263050/src/_pytest/python.py#L1085
5. inconsistent-return-statements:
   Either all return statements in a function should return an expression, or none of them should.
   https://github.com/pytest-dev/pytest/blob/50b232b0cb39490776da2658ae69c669ce263050/src/_pytest/fixtures.py#L130
6. inconsistent-return-statements:
   Either all return statements in a function should return an expression, or none of them should.
   https://github.com/pytest-dev/pytest/blob/50b232b0cb39490776da2658ae69c669ce263050/src/_pytest/python_api.py#L798
7. no-name-in-module:
   No name 'NOSE_SUPPORT' in module '_pytest.deprecated'
   https://github.com/pytest-dev/pytest/blob/50b232b0cb39490776da2658ae69c669ce263050/src/_pytest/nose.py#L5
8. no-name-in-module:
   No name 'warn_explicit_for' in module '_pytest.warning_types'
   https://github.com/pytest-dev/pytest/blob/50b232b0cb39490776da2658ae69c669ce263050/src/_pytest/config/__init__.py#L62
9. no-member:
   Module '_pytest.deprecated' has no 'HOOK_LEGACY_MARKING' member
   https://github.com/pytest-dev/pytest/blob/50b232b0cb39490776da2658ae69c669ce263050/src/_pytest/config/__init__.py#L369

This comment was generated for commit 266c0f5