Moved parallel execution code outside of PyLinter #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -841,8 +887,7 @@ def expand_modules(files_or_modules, black_list, black_list_re): | |||
| is_directory = spec.type == modutils.ModuleType.PKG_DIRECTORY | |||
|
|
|||
| if not is_namespace: | |||
| result.append({'path': filepath, 'name': modname, 'isarg': True, | |||
| 'basepath': filepath, 'basename': modname}) | |||
| result.append(ModuleDescription(filepath, modname, True, filepath, modname)) | |||
There was a problem hiding this comment.
Can you make isarg a keyword argument, so that thi becomes ModuleDescription(filepath, modname, isarg=True)?
|
Looks good. Two small comments and it will be ready to merge. |
|
Looks good to me, feel free to merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PyLinter object is still very dependent on having certain operation performed on it in order. Hence why the parallel code is often calling methods on
self.linter. As we move towards a linter object being used for a single file, it would be good to eliminate these.Implements #936