Minor fixups

py-pdf · May 8, 2023 · e208ab4 · e208ab4
1 parent 47e910f
commit e208ab4
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 11 deletions.
diff --git a/docs/Transformations.md b/docs/Transformations.md
@@ -45,11 +45,11 @@ with pdf.skew(ax=-45, ay=0, x=100, y=170):
 
 ## Mirror ##
 
+_New in [:octicons-tag-24: 2.7.5](https://github.com/PyFPDF/fpdf2/blob/master/CHANGELOG.md)_
 The `mirror` context-manager applies a mirror transformation to all objects inserted in its indented block over a given mirror line by specifying starting co-ordinate and angle.
 
 ```python
-x = 100
-y = 100
+x, y = 100, 100
 pdf.text(x, y, txt="mirror this text")
 with pdf.mirror((x, y), "EAST"):
     pdf.set_text_color(r=255, g=128, b=0)

diff --git a/fpdf/fpdf.py b/fpdf/fpdf.py
@@ -2585,12 +2585,10 @@ def mirror(self, origin, angle):
         context (with the exception of clickable areas).
 
         Args:
-            origin (Sequence(float, float)): a point on the mirror line
+            origin (float, Sequence(float, float)): a point on the mirror line
             angle: (fpdf.enums.Angle): the direction of the mirror line
         """
-        angle = Angle.coerce(angle)
         x, y = origin
-
         try:
             theta = Angle.coerce(angle).value
         except ValueError:

diff --git a/test/mirror_multi_cell.pdf b/test/mirror_multi_cell.pdf
diff --git a/help.pdf → test/mirror_with_angle_as_number.pdf b/help.pdf → test/mirror_with_angle_as_number.pdf
diff --git a/test/test_mirror.py b/test/test_mirror.py
@@ -16,15 +16,14 @@ def draw_mirror_line(pdf, origin, angle):
 
     Args:
         pdf (fpdf.FPDF): pdf to modify
-        origin (Sequence[float, float]): a point on the mirror line
+        origin (float, Sequence[float, float]): a point on the mirror line
         angle: (fpdf.enums.Angle): the direction of the mirror line
     """
-
-    angle = Angle.coerce(angle)
-
     x, y = origin
-
-    theta = angle.value
+    try:
+        theta = Angle.coerce(angle).value
+    except ValueError:
+        theta = angle
 
     cos_theta, sin_theta = (
         math.cos(math.radians(theta)),
@@ -71,6 +70,18 @@ def test_mirror(tmp_path):
     assert_pdf_equal(pdf, HERE / "mirror.pdf", tmp_path)
 
 
+def test_mirror_with_angle_as_number(tmp_path):
+    pdf = FPDF()
+    pdf.set_font("helvetica", size=50)
+    pdf.add_page()
+    x, y = 50, 50
+    pdf.text(x, y, txt="mirror this text")
+    with pdf.mirror((x, y), 180):
+        pdf.set_text_color(r=255, g=128, b=0)
+        pdf.text(x, y, txt="mirror this text")
+    assert_pdf_equal(pdf, HERE / "mirror_with_angle_as_number.pdf", tmp_path)
+
+
 def test_mirror_text(tmp_path):
     pdf = FPDF()
     pdf.add_page()