Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parse_csv in templates to parse numbers #205

Merged
merged 3 commits into from
Aug 22, 2021

Conversation

alexp1917
Copy link
Collaborator

closes #182

@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #205 (40345d4) into master (cc0cf83) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   84.21%   84.25%   +0.03%     
==========================================
  Files          16       16              
  Lines        3516     3531      +15     
  Branches      708      711       +3     
==========================================
+ Hits         2961     2975      +14     
- Misses        371      372       +1     
  Partials      184      184              
Impacted Files Coverage Δ
fpdf/fpdf.py 81.97% <100.00%> (ø)
fpdf/template.py 56.04% <100.00%> (+1.18%) ⬆️
fpdf/util.py 84.00% <100.00%> (+3.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0cf83...40345d4. Read the comment docs.

@alexp1917
Copy link
Collaborator Author

oh, it asks for code owners review by default, i did not know this haha, i thought everyone just wanted my attention on things. Good to know that its in fact a robot bothering me and not contributors 🤦

@alexp1917
Copy link
Collaborator Author

alexp1917 commented Aug 22, 2021

you may want to change tuple([[ to tuple([tuple([ but other than that this ones good to go in my opinion.

@Lucas-C Lucas-C merged commit 247d045 into master Aug 22, 2021
@Lucas-C Lucas-C deleted the fix_csv_template_parse_numbers branch August 22, 2021 09:16
@Lucas-C
Copy link
Member

Lucas-C commented Sep 1, 2021

This has just been released in fpdf2.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants