Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Tutorial-km-md #799

Closed
wants to merge 1 commit into from
Closed

Create Tutorial-km-md #799

wants to merge 1 commit into from

Conversation

kuth-chi
Copy link

@kuth-chi kuth-chi commented Jun 3, 2023

I add Tutorial in Khmer

e.g. Fixes #0

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

I add Tutorial in Khmer
@kuth-chi kuth-chi requested a review from Lucas-C as a code owner June 3, 2023 14:00
@kuth-chi
Copy link
Author

kuth-chi commented Jun 4, 2023

Please check my pull request to main.

@Lucas-C
Copy link
Member

Lucas-C commented Jun 5, 2023

@allcontributors please add @kuth-chi for translation

@allcontributors
Copy link

@Lucas-C

I've put up a pull request to add @kuth-chi! 🎉

@Lucas-C
Copy link
Member

Lucas-C commented Jun 5, 2023

Thank you for this translation @kuth-chi!

The PR looks great!

There are a few of extra things that should be added,
to integrate this translated tutorial similarly to the other ones:

  • a mention in the file named CHANGELOG.md, about this new translation
    (the file already contains mentions of previous translations being added, that can serve as examples to you)
  • add a link to your tutorial in the file named README.md, in the "Documentation" section, similar to the other ones
  • add a link to your tutorial in docs/index.md, in the "Tutorials" section, similar to the other ones

@kuth-chi: would like to include this as part of this Pull Request?
Else, I can merge your contribution and add them myself afterward.

@Lucas-C Lucas-C mentioned this pull request Jun 5, 2023
5 tasks
@kuth-chi kuth-chi closed this Jun 7, 2023
@kuth-chi kuth-chi deleted the patch-2 branch June 7, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants