Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect docstring #382

Closed
lurch opened this issue Apr 10, 2020 · 1 comment · Fixed by #434
Closed

Incorrect docstring #382

lurch opened this issue Apr 10, 2020 · 1 comment · Fixed by #434
Labels
docs Issues related to documentation
Milestone
v2.4.12

Comments

@lurch
Copy link
Contributor

lurch commented Apr 10, 2020

The docstring for Mode.to_platform contains "Currently, this just removes the 'x' on PY2 because PY2 doesn't support exclusive mode." which seems to be correct. However that same snippet is also included in the docstring for Mode.to_platform_bin where it appears to be incorrect.
@althonos althonos added the docs Issues related to documentation label Sep 17, 2020
@althonos althonos added this to the v2.4.12 milestone Sep 17, 2020
@althonos althonos mentioned this issue Oct 13, 2020
Merged
4 tasks
@althonos
Copy link
Member

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Issues related to documentation
Projects
None yet
Milestone
v2.4.12
Development

Successfully merging a pull request may close this issue.

Documentation fixes for release v2.4.12 PyFilesystem/pyfilesystem2
2 participants
@lurch @althonos