Skip to content

Commit

Permalink
Remove comments meant for review from docs
Browse files Browse the repository at this point in the history
  • Loading branch information
Cito committed Jan 6, 2019
1 parent 2de3b87 commit 4cbc6da
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
2 changes: 1 addition & 1 deletion docs/contents/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ ChangeLog
Version 5.1 (2019-mm-dd)
------------------------
- Support for prepared statements has been added to the classic API.
- DB wrapper objects based on existing connections can not be closed and
- DB wrapper objects based on existing connections can now be closed and
reopened properly (but the underlying connection will not be affected).

Vesion 5.0.7 (2019-mm-dd)
Expand Down
8 changes: 0 additions & 8 deletions docs/contents/pg/db_wrapper.rst
Original file line number Diff line number Diff line change
Expand Up @@ -247,14 +247,6 @@ begin/commit/rollback/savepoint/release -- transaction handling

This commits the current transaction.

All changes made by the transaction become visible to others.
=> Don't say this, since it's not true eg. in repeatable_read xtn
After returning, the changes are guaranteed to be durable, even if a crash occurs.
=> Don't say this since it's postgres job to document DB behavior,
kernel and library folks job to do their part, and DBA+sysadmin job to
implement it on site, not pygres or the developer's job
(with my developer's hat off and sysadmin hat on).

.. method:: DB.end()

This is the same as the :meth:`DB.commit` method.
Expand Down

0 comments on commit 4cbc6da

Please sign in to comment.