Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyleco for python 3.8 #277

Open
BenediktBurger opened this issue Feb 24, 2024 · 9 comments
Open

Pyleco for python 3.8 #277

BenediktBurger opened this issue Feb 24, 2024 · 9 comments

Comments

@BenediktBurger
Copy link
Contributor

In pymeasure/pyleco#61 I successfully reduced the requirement to Python 3.8 by replacing the dependency by my own code and changing typing.

Python 3.7 failed due to setup tools I have to investigate, whether I can achieve Python 3.7.

Due to the larger changes, I will have to test it, before doing a release.

@seb5g
Copy link
Contributor

seb5g commented Feb 24, 2024

thanks a lot @BenediktBurger

@BenediktBurger
Copy link
Contributor Author

python 3.7 requires dropping typing.Protocol, which I use extensively.
With more effort and pain, we could reduce the requirements to Python 3.7, but I prefer starting at 3.8.

@seb5g
Copy link
Contributor

seb5g commented Feb 26, 2024

For python 3.8+ you can use https://pypi.org/project/typing-extensions/ if some python versions lacks typing utilities you're using!

Unfortunately they don't do it for python 3.7...

@BenediktBurger
Copy link
Contributor Author

I reorganized some things, such that I could publish a pyleco 0.3 version for python>=3.8.
Would you prefer an earlier release (these days) or don't you care if it comes later?
In the latter case, I can address some small issues as well.

@seb5g
Copy link
Contributor

seb5g commented Mar 7, 2024

nothing urgent on our side @rgeneaux did'nt come back with use case issues yet ;-)

@rgeneaux
Copy link
Collaborator

rgeneaux commented Mar 7, 2024

yes we're working on the laser side of things for a while so software questions will come later - take your time Benedikt!

@BenediktBurger
Copy link
Contributor Author

Pyleco 0.3.0 is out with support for Python 3.8.

@seb5g
Copy link
Contributor

seb5g commented Mar 14, 2024

Awesome I'll be able to include it in the next minor release

@BenediktBurger
Copy link
Contributor Author

BenediktBurger commented Mar 14, 2024

I reopened the issue such that it is a reminder to adjust the requirements, when to install pyleco.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants