Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.11.1 and 3.12 alphas need additional path configuration on Windows #2817

Closed
davidhewitt opened this issue Dec 18, 2022 · 1 comment
Closed

3.11.1 and 3.12 alphas need additional path configuration on Windows #2817

davidhewitt opened this issue Dec 18, 2022 · 1 comment

Comments

@davidhewitt
Copy link
Member

See https://github.com/PyO3/pyo3/actions/runs/3721944864/jobs/6312442577#step:11:1094 - we have CI failures on Windows along the lines of

thread 'exceptions::asyncio::tests::TimeoutError' panicked at 'Can not import module asyncio: ModuleNotFoundError: No module named '_socket'

Appears to be the following upstream issue: python/cpython#100171

We may need to do something smarter in auto-initialize depending on what the outcome of decisions upstream are. We have had several issues of interacting with virtualenvs in the past, e.g. #1741 #1896, maybe it's now time anyway to implement a new "default" in prepare_freethreaded_python which covers what users are most likely to want?
This was referenced Dec 18, 2022
Closed
Merged
Merged
bors bot added a commit that referenced this issue Dec 18, 2022
@bors @davidhewitt
Merge #2821
b88ad83 
2821: ci: pin more to 3.11.0 r=davidhewitt a=davidhewitt

Still getting some windows failures due to #2817. Pin more stuff for now :(

Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
bors bot added a commit that referenced this issue Dec 18, 2022
@bors @davidhewitt
Merge #2821
9082c5c 
2821: ci: pin more to 3.11.0 r=davidhewitt a=davidhewitt

Still getting some windows failures due to #2817. Pin more stuff for now :(

Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
@davidhewitt davidhewitt mentioned this issue Jan 27, 2023
Merged
@davidhewitt davidhewitt mentioned this issue Feb 14, 2023
Open
@davidhewitt davidhewitt mentioned this issue Feb 27, 2023
Merged
bors bot added a commit that referenced this issue Feb 28, 2023
@bors @davidhewitt
Merge #2990 #2991
794755c 
2990: Fix `clippy::redundant_closure` lint firing for pyfunction defaults r=adamreichold a=davidhewitt

Fixes #2988

I'll push a follow-up for the FIXME as a separate PR.

2991: unpin 3.11 ci jobs r=adamreichold a=davidhewitt

With Python 3.11.2 released for a couple weeks now, I think #2817 is probably not an issue in CI any more.

Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
@davidhewitt davidhewitt mentioned this issue Apr 11, 2023
Merged
@davidhewitt
Copy link
Member Author

It seems this is no longer the case.

@davidhewitt davidhewitt closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidhewitt