Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: incorrect wheel names #1777

Closed
1 of 2 tasks
0-wiz-0 opened this issue Sep 26, 2023 · 2 comments · Fixed by #1778
Closed
1 of 2 tasks

macOS: incorrect wheel names #1777

0-wiz-0 opened this issue Sep 26, 2023 · 2 comments · Fixed by #1778
Labels
bug Something isn't working wheel Wheel

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Sep 26, 2023

Bug Description

We've packaged https://github.com/crate-py/rpds for pkgsrc, and it uses maturin to build. This works nicely on many platforms, but we see a packaging problem on macOS.

Our build process generates a wheel and then installs it.

The actual problem is that the file name for the wheel is rpds_py-0.10.0-cp311-cp311-macosx_11_3_arm64.whl, but that platform is not accepted by pip.

Installing the package throws the error:

ERROR: rpds_py-0.10.0-cp311-cp311-macosx_11_3_arm64.whl is not a supported wheel on this platform.

pip --verbose debug lists the following (close) values as acceptable:

  cp311-cp311-macosx_13_0_arm64                                                                                                                                                                                                                                                                           
  cp311-cp311-macosx_13_0_universal2                                                                                                                                                                                                                                                                      
  cp311-cp311-macosx_12_0_arm64                                                                                                                                                                                                                                                                           
  cp311-cp311-macosx_12_0_universal2                                                                                                                                                                                                                                                                      
  cp311-cp311-macosx_11_0_arm64                                                                                                                                                                                                                                                                           
  cp311-cp311-macosx_11_0_universal2                                                                                                                                                                                                                                                                      
  cp311-cp311-macosx_10_16_universal2                                                                                                                                                                                                                                                                     
  cp311-cp311-macosx_10_15_universal2                                                                                                                                                                                                                                                                     
  cp311-cp311-macosx_10_14_universal2                                                                                                                                                                                                                                                                     
  cp311-cp311-macosx_10_13_universal2                                                                                                                                                                                                                                                                     
  cp311-cp311-macosx_10_12_universal2                                                                                                                                                                                                                                                                     
  cp311-cp311-macosx_10_11_universal2                                                                                                                                                                                                                                                                     
  cp311-cp311-macosx_10_10_universal2                                                                                                                                                                                                                                                                     
  cp311-cp311-macosx_10_9_universal2                                                                                                                                                                                                                                                                      
  cp311-cp311-macosx_10_8_universal2                                                                                                                                                                                                                                                                      
  cp311-cp311-macosx_10_7_universal2                                                                                                                                                                                                                                                                      
  cp311-cp311-macosx_10_6_universal2                                                                                                                                                                                                                                                                      
  cp311-cp311-macosx_10_5_universal2                                                                                                                                                                                                                                                                      
  cp311-cp311-macosx_10_4_universal2                                                                                                                                                                                                                                                                      

I looked at the rpds github CI flow, and it creates wheel for 10_7, which don't have this problem.

Your maturin version (maturin --version)

1.2.3

Your Python version (python -V)

Python 3.11.5

Your pip version (pip -V)

23.2.1

What bindings you're using

None

Does cargo build work?

  • Yes, it works

If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)?

  • Yes

Steps to Reproduce

See above.

@messense
Copy link
Member

For now you can workaround it by setting MACOSX_DEPLOYMENT_TARGET=11.0 env var.

@0-wiz-0
Copy link
Author

0-wiz-0 commented Sep 28, 2023

Thanks. I added the patch to pkgsrc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wheel Wheel
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants