Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auditwheel: generate single wheel for multiple eligible manylinux tags #523

Closed
messense opened this issue May 5, 2021 · 5 comments
Closed

Comments

@messense
Copy link
Member

messense commented May 5, 2021

  1. Always repair as a single wheel pypa/auditwheel#289
  2. test: update expected wheels when using auditwheel >= 4 pypa/cibuildwheel#633 (comment)

This will make it possible to support manylinux1 wheel with --manylinux 2010 and later even if Rust doesn't run on CentOS 5.

@konstin
Copy link
Member

konstin commented May 6, 2021

What's the advantage of tagging multiple manylinux versions instead of just tagging the oldest one possible?

@messense
Copy link
Member Author

messense commented May 6, 2021

What's the advantage of tagging multiple manylinux versions instead of just tagging the oldest one possible?

I guess if we just tagging the oldest one there is no advantage. But if --manylinux $VERSION is passed, currently maturin only generate the specified tag which probably isn't the oldest tag. It's nice to have maturin's behavior aligned with the official auditwheel package.

@konstin
Copy link
Member

konstin commented May 6, 2021

TBH I wrote maturin because I disagree with the behaviour of the official tools. They are often counterintuitive and lead to projects badly broken in subtle ways, which regularly causes problems in across different projects. I wanted maturin to be something that might support less things, but does them correctly.

For --manylinux $VERSION, I believe that we should only tag $VERSION. Ultimately, maintainers should control what the lowest supported version is and maturin should not arbitrarily overrule that. For those who just want the defaults, I recommend the manylinux 2_17 image with --manylinux 2_17 due to arm support.

@messense
Copy link
Member Author

messense commented May 6, 2021

I understand your concern. It's just not clear to me what kind of problem will this feature cause in practice, can you give some examples?

@konstin
Copy link
Member

konstin commented May 8, 2021

I don't have any concrete examples, but from my experience software trying to be smarter than what the user explicitly requested always leads to problems eventually. With default options maturin is already tagging the lowest possible version and we also have the warning saying when a lower version would be possible, so imho this would only be a small gain.

Sorry for rejecting this, I know this seems like an easy win but I think we're better off with just tagging the requested version.

@konstin konstin closed this as completed May 8, 2021
@messense messense removed the enhancement New feature or request label May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants