Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.6 Release coordination #404

Closed
1 task done
konstin opened this issue Mar 18, 2019 · 5 comments
Closed
1 task done

0.6 Release coordination #404

konstin opened this issue Mar 18, 2019 · 5 comments
Assignees

Comments

@konstin
Copy link
Member

konstin commented Mar 18, 2019

We've already got more than enough changes for a new release, so we should make one.

I'll merge #388 after CI passes, but otherwise I'd just bump versions and publish to crates.io. After that we can remove python 2 support and merge #382. Pypy support (#393) will become part of a later release.

@pganssle I remember that you wanted to get some changes to the datetime module merged before the release.

@kngwyu You added #381 to the 0.6 milestone; Do you want to solve that issue before the release?

@konstin konstin self-assigned this Mar 18, 2019
@kngwyu
Copy link
Member

kngwyu commented Mar 18, 2019

Do you want to solve that issue before the release?

I do but I don't have enough time this week.
And I also fear some regressions introduced by PyRef like #356 (comment).

@pganssle
Copy link
Member

@konstin I've created a new bug, #405, to track the stuff I wanted to change in datetime. Not sure if I can get to it this week, possibly this weekend?

@konstin
Copy link
Member Author

konstin commented Mar 21, 2019

@pganssle I don't think those api changes are critical to be part of the release.

However, I realized that #341 (comment) is a regression from 0.5 which should be investigated. I've added it to the original post.

@konstin
Copy link
Member Author

konstin commented Mar 26, 2019

I've tried to minimize #341and found out that declaring the unsafe extern "C" fn __wrap functions inside of inventory::submit is what break linking. The solution would be to declare them outside of that macro with unique name. However I won't get to doing that anytime soon, so I'd suggest we just make the release and mention the regression in the changelog.

@konstin
Copy link
Member Author

konstin commented Mar 28, 2019

I've released 0.6.0 on crates.io and github. Now we just need to wait for travis to update the docs

@konstin konstin closed this as completed Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants