Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the tool table to scope #11

Open
cnpryer opened this issue Apr 25, 2023 · 4 comments · May be fixed by #21
Open

Adding the tool table to scope #11

cnpryer opened this issue Apr 25, 2023 · 4 comments · May be fixed by #21

Comments

@cnpryer
Copy link
Contributor

cnpryer commented Apr 25, 2023

Having used pyproject-toml myself, I'd prefer this as well.

AFAIK to do this you have to add it to a wrapper around PyProjectToml, since it's specifically just core metadata currently. It'd be nice to add this to the scope.

The tool table is mentioned in both PEP 621 and PEP 518, accepted and finalized PEPs.

I'm happy to work on this once I open up some time to (if you're okay with this change, of course).

@messense
Copy link
Member

I'm ok with it as long as parsing tool table to a struct in downstream is doable and easy.

@konstin
Copy link
Member

konstin commented Apr 26, 2023

There's two options here: parse the tool section into a toml Table or parse it into a user-provided T and parameterize everything with T

@adamreichold
Copy link
Member

I think the Table is preferable as it can be easily transform into other Serializable types via its try_into method.

As a compromise, one could also parametrize everything on a user-defined type but at least default it to Table.

@cnpryer
Copy link
Contributor Author

cnpryer commented Apr 26, 2023

For visibility, I'm not yet able to snag this (or #10). I don't want to hold any progress up in case someone comes and gets to these before me. I could probably look at them this or next weekend.

If not it's definitely on my todo list, just not super high priority for what I personally need, but I'd like to see more projects using this crate. So it's up there.

Thanks for the ideas though, everyone!

@bschoenmaeckers bschoenmaeckers linked a pull request Mar 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants