Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misapplication of ancient snakemake keyword #1073

Closed
2 tasks done
koen-vg opened this issue May 21, 2024 · 1 comment
Closed
2 tasks done

Misapplication of ancient snakemake keyword #1073

koen-vg opened this issue May 21, 2024 · 1 comment
Labels

Comments

@koen-vg
Copy link
Contributor

koen-vg commented May 21, 2024

It looks like the recent commit marking the databundle as ancient instead of protected isn't really working; ancient is only supposed to be used for inputs, not outputs. Somehow it looks like it's actually making the whole workflow re-run every time for me.

I think maybe it would be an idea to write a little piece of Python code in retrieve.smk to check if all the databundle output files exist, and only define the retrieval rule if they don't. That should make it so snakemake really doesn't try to re-run the data bundle retrieval unless file are added or you manually delete it.

I do get the motivation because whenever I rebase anything, snakemake usually says that the code changed and it want to re-run the data retrieval.

Checklist

  • I am using the current master branch or the latest release. Please indicate.
  • I am running on an up-to-date pypsa-eur environment. Update via conda env update -f envs/environment.yaml.
@koen-vg koen-vg added the bug label May 21, 2024
@koen-vg
Copy link
Contributor Author

koen-vg commented May 21, 2024

I'll see if I get around to a PR today.

@koen-vg koen-vg closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant