Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish setting up pre-commit #268

Closed
trevorb1 opened this issue Apr 11, 2024 · 0 comments · Fixed by #269
Closed

Finish setting up pre-commit #268

trevorb1 opened this issue Apr 11, 2024 · 0 comments · Fixed by #269
Assignees
Labels
enhancement New feature or request

Comments

@trevorb1
Copy link
Collaborator

Feature Request

We should really finish setting up pre-commit. I guess Black isnt liking our Reorder python imports, and maybe an issue with pyupgrade as well.

Suggested Solution

No response

Additional Info

[WARNING] The top-level 'exclude' field is a regex, not a glob -- matching '/*' probably isn't what you want here
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
debug statements (python)................................................Passed
fix python encoding pragma (deprecated)..................................Failed
- hook id: fix-encoding-pragma
- exit code: 1
- files were modified by this hook

warning: this hook is deprecated and will be removed in a future release because py2 is EOL. instead, use https://github.com/asottile/pyupgrade
Added `# -*- coding: utf-8 -*-` to workflow/scripts/constants.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/summary_natural_gas.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/solve_network.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/regional_dashboard.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/build_cop_profiles.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/build_natural_gas.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/build_renewable_profiles.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/simplify_network.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/add_extra_components.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/summary.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/build_heat_demands.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/plot_network_maps.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/build_shapes.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/add_sectors.py
Added `# -*- coding: utf-8 -*-` to docs/source/conf.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/build_population_layouts.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/_helpers.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/eia.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/build_bus_regions.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/retrieve_eia_data.py
Added `# -*- coding: utf-8 -*-` to workflow/tests/test_yaml_structure.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/log.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/generate_stochastic_samples.py
warning: this hook is deprecated and will be removed in a future release because py2 is EOL. instead, use https://github.com/asottile/pyupgrade
Added `# -*- coding: utf-8 -*-` to workflow/scripts/build_cutout.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/plot_statistics.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/build_cost_data.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/build_demand.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/retrieve_cost_data_usa.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/retrieve_eulp.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/add_electricity.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/build_base_network.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/plot_natural_gas.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/retrieve_caiso_data.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/modify_network_osw.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/build_clustered_population_layouts.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/retrieve_cost_data_eur.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/build_hydro_profile.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/prepare_network.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/cluster_network.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/build_temperature_profiles.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/build_fuel_prices.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/retrieve_forecast_data.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/plot_validation_production.py
Added `# -*- coding: utf-8 -*-` to workflow/scripts/retrieve_databundles.py

mixed line ending........................................................Passed
check for added large files..............................................Passed
Pretty format YAML.......................................................Passed
Reorder python imports...................................................Failed
- hook id: reorder-python-imports
- exit code: 2

usage: reorder-python-imports [-h] [--exit-zero-even-if-changed]
                              [--add-import ADD_IMPORT]
                              [--remove-import REMOVE_IMPORT]
                              [--replace-import REPLACE_IMPORT]
                              [--application-directories APPLICATION_DIRECTORIES]
                              [--unclassifiable-application-module UNCLASSIFIABLE]
                              [--py22-plus] [--py23-plus] [--py26-plus]
                              [--py3-plus] [--py36-plus] [--py37-plus]
                              [--py38-plus] [--py39-plus] [--py310-plus]
                              [--py311-plus] [--py312-plus]
                              [filenames ...]
reorder-python-imports: error: argument --add-import: expected import: 'workflow/scripts/constants.py'
usage: reorder-python-imports [-h] [--exit-zero-even-if-changed]
                              [--add-import ADD_IMPORT]
                              [--remove-import REMOVE_IMPORT]
                              [--replace-import REPLACE_IMPORT]
                              [--application-directories APPLICATION_DIRECTORIES]
                              [--unclassifiable-application-module UNCLASSIFIABLE]
                              [--py22-plus] [--py23-plus] [--py26-plus]
                              [--py3-plus] [--py36-plus] [--py37-plus]
                              [--py38-plus] [--py39-plus] [--py310-plus]
                              [--py311-plus] [--py312-plus]
                              [filenames ...]
reorder-python-imports: error: argument --add-import: expected import: 'workflow/scripts/build_cutout.py'

Add trailing commas......................................................Passed
pyupgrade................................................................Failed
- hook id: pyupgrade
- exit code: 1
- files were modified by this hook

Rewriting workflow/scripts/constants.py
Rewriting workflow/scripts/summary_natural_gas.py
Rewriting workflow/scripts/solve_network.py
Rewriting workflow/scripts/regional_dashboard.py
Rewriting workflow/scripts/build_cop_profiles.py
Rewriting workflow/scripts/build_natural_gas.py
Rewriting workflow/scripts/build_renewable_profiles.py
Rewriting workflow/scripts/simplify_network.py
Rewriting workflow/scripts/add_extra_components.py
Rewriting workflow/scripts/summary.py
Rewriting workflow/scripts/build_heat_demands.py
Rewriting workflow/scripts/plot_network_maps.py
Rewriting workflow/scripts/build_shapes.py
Rewriting workflow/scripts/add_sectors.py
Rewriting docs/source/conf.py
Rewriting workflow/scripts/build_population_layouts.py
Rewriting workflow/scripts/_helpers.py
Rewriting workflow/scripts/eia.py
Rewriting workflow/scripts/build_bus_regions.py
Rewriting workflow/scripts/retrieve_eia_data.py
Rewriting workflow/tests/test_yaml_structure.py
Rewriting workflow/scripts/log.py
Rewriting workflow/scripts/generate_stochastic_samples.py
Rewriting workflow/scripts/build_cutout.py
Rewriting workflow/scripts/plot_statistics.py
Rewriting workflow/scripts/build_cost_data.py
Rewriting workflow/scripts/build_demand.py
Rewriting workflow/scripts/retrieve_cost_data_usa.py
Rewriting workflow/scripts/retrieve_eulp.py
Rewriting workflow/scripts/add_electricity.py
Rewriting workflow/scripts/build_base_network.py
Rewriting workflow/scripts/plot_natural_gas.py
Rewriting workflow/scripts/retrieve_caiso_data.py
Rewriting workflow/scripts/modify_network_osw.py
Rewriting workflow/scripts/build_clustered_population_layouts.py
Rewriting workflow/scripts/retrieve_cost_data_eur.py
Rewriting workflow/scripts/build_hydro_profile.py
Rewriting workflow/scripts/prepare_network.py
Rewriting workflow/scripts/cluster_network.py
Rewriting workflow/scripts/build_temperature_profiles.py
Rewriting workflow/scripts/build_fuel_prices.py
Rewriting workflow/scripts/retrieve_forecast_data.py
Rewriting workflow/scripts/plot_validation_production.py
Rewriting workflow/scripts/retrieve_databundles.py

jupyter-notebook-cleanup.................................................Passed
snakefmt.................................................................Passed
docformatter.............................................................Failed
- hook id: docformatter
- exit code: 3
- files were modified by this hook
blackdoc.................................................................Passed
black....................................................................Failed
- hook id: black
- files were modified by this hook

reformatted workflow/scripts/plot_validation_production.py

All done! ✨ 🍰 ✨
1 file reformatted, 44 files left unchanged.

black-jupyter............................................................Passed
@trevorb1 trevorb1 added the enhancement New feature or request label Apr 11, 2024
@trevorb1 trevorb1 mentioned this issue Apr 11, 2024
5 tasks
@trevorb1 trevorb1 self-assigned this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant